Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta_storage: support delete interface #7096

Merged
merged 3 commits into from
Feb 26, 2024
Merged

meta_storage: support delete interface #7096

merged 3 commits into from
Feb 26, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Sep 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5851, tikv/tikv#14484

What is changed and how does it work?

This PR adds the basic delete function
Here is the proto definition: https://github.com/pingcap/kvproto/pull/1226

mysql> CREATE RESOURCE GROUP IF NOT EXISTS rg1 RU_PER_SEC = 500 BURSTABLE;
Query OK, 0 rows affected (0.16 sec)

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+-----------+-------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
| rg1     | 500        | MEDIUM   | YES       | NULL        | NULL       |
+---------+------------+----------+-----------+-------------+------------+
2 rows in set (0.00 sec)

mysql> DROP RESOURCE GROUP IF EXISTS rg1;
Query OK, 0 rows affected (0.15 sec)

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+-----------+-------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
+---------+------------+----------+-----------+-------------+------------+
1 row in set (0.00 sec)

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

meta_storage: support delete interface

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 14, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx September 14, 2023 09:51
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
merge master
20bf5a8 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the support_meta_delete branch from 48fce2f to 20bf5a8 Compare February 21, 2024 09:48
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2024
@HuSharp HuSharp mentioned this pull request Feb 21, 2024
Merged
@HuSharp
update gomod
a7ad4c6 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

Merging #7096 (492fd2b) into master (d21c626) will decrease coverage by 0.10%.
The diff coverage is 28.57%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7096      +/-   ##
==========================================
- Coverage   73.52%   73.42%   -0.10%     
==========================================
  Files         432      432              
  Lines       47915    47937      +22     
==========================================
- Hits        35229    35199      -30     
- Misses       9645     9684      +39     
- Partials     3041     3054      +13
Flag Coverage Δ
unittests 73.42% <28.57%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp marked this pull request as ready for review February 22, 2024 03:15
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@HuSharp HuSharp requested a review from nolouch February 22, 2024 03:15
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue labels Feb 22, 2024
@HuSharp HuSharp removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2024
@HuSharp HuSharp mentioned this pull request Feb 22, 2024
Merged
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 26, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Feb 26, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 492fd2b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit e199866 into tikv:master Feb 26, 2024
23 of 26 checks passed
@HuSharp HuSharp deleted the support_meta_delete branch February 26, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @JmPotato @nolouch